Conversation
Lyra-B
force-pushed
the
FRI-15467
branch
2 times, most recently
from
c3d294e to
5b7c8cd
Compare
When the API returns a non-2xx response with a body that isn't a valid JSON error envelope (e.g. an HTML page from Cloudflare), the SDK previously threw MalformedResponseException with no indication of the underlying HTTP status, making it hard to distinguish a WAF 403 from an edge 5xx during triage. Expose the status code via getStatusCode() and include it in the exception message alongside a truncated body preview.
Contributor
Author
|
Applied this in the template instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the API returns a non-2xx response with a body that isn't a valid
JSON error envelope (e.g. an HTML page from Cloudflare), the SDK
previously threw MalformedResponseException with no indication of the
underlying HTTP status, making it hard to distinguish a WAF 403 from
an edge 5xx during triage.
Expose the status code via getStatusCode() and include it in the
exception message alongside a truncated body preview.